Drop python3.8 support

[RyanBalfanz]

Closes #

Python 3.8 EOL date was 2024-10-07.

See #824 for prior art, dropping Python 3.7.

💸 TL;DR

Drops Python v3.8 support.

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

• CI tests (if present) are passing
• Adheres to code style for repo
• Contributor License Agreement (CLA) completed if not a Reddit employee

[RyanBalfanz]

Note: I installed the version that is installed explicitly in the Dockerfile, hence the version change.

[mathyourlife-reddit]

Looks like updates are consistent with the 3.7 drop and test are 🟢 . Seems reasonable to me, would also like a 👍 from @chriskuehl before merging.

[RyanBalfanz]

Looks like updates are consistent with the 3.7 drop and test are 🟢 . Seems reasonable to me, would also like a 👍 from @chriskuehl before merging.

3.7 drop didn't require an updated poetry.lock but CI was failing without it, so I am keen to call that out here

[chriskuehl]

Thanks for taking care of this!

[chriskuehl]

3.7 drop didn't require an updated poetry.lock but CI was failing without it, so I am keen to call that out here

This looks good to me. Needing to update the poetry.lock is expected when you change the pyproject.toml since it contains a hash of the important fields, and also it may need to adjust the package versions if you change dependencies. You can use poetry lock --no-update to do a minimal update (should be fast as it only fixes the stuff it needs to), or poetry lock (which can be slow and pull in a ton of updates).

Worth saying explicitly that poetry.lock does not affect users of Baseplate in any way. It's only used for Baseplate's own tests and local development, and is not even included in the sdist or wheel. So, even if you run poetry lock and pull in more changes than necessary, it has no impact on users so there is zero risk here.