Drop python3.8 support (#1003)

* Drop python3.8 support * `poetry lock` * Set tool.black.target-version back to py38 * Disable too-many-positional-arguments * fix: Unused "type: ignore" comment * Set tool.black.target-version to py39
reddit · Oct 23, 2024 · fe59ab2 · fe59ab2
1 parent aba90a0
commit fe59ab2
Show file tree

Hide file tree

Showing 7 changed files with 1,279 additions and 1,260 deletions.
diff --git a/.github/workflows/python-package.yaml b/.github/workflows/python-package.yaml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.9', '3.10', '3.11', '3.12']
 
     container:
       image: python:${{ matrix.python-version }}

diff --git a/baseplate/frameworks/thrift/command.py b/baseplate/frameworks/thrift/command.py
@@ -19,7 +19,7 @@ def finalize_options(self) -> None:
         self.set_undefined_options("build", ("build_base", "build_base"))
 
     def run(self) -> None:
-        if self.dry_run:  # type: ignore
+        if self.dry_run:
             return
 
         temp_dir = os.path.join(self.build_base, "thrift")  # type: ignore

diff --git a/docs/pyproject.toml b/docs/pyproject.toml
@@ -5,4 +5,4 @@ line-length = 74
 
 # Always use our latest supported version here since we want code snippets in
 # docs to use the most up-to-date syntax.
-target-version = ['py38']
+target-version = ['py39']
diff --git a/poetry.lock b/poetry.lock
diff --git a/pylintrc b/pylintrc
@@ -53,6 +53,7 @@ disable= attribute-defined-outside-init,
          too-many-lines,
          too-many-locals,
          too-many-nested-blocks,
+         too-many-positional-arguments,
          too-many-public-methods,
          too-many-return-statements,
          too-many-statements,

diff --git a/pyproject.toml b/pyproject.toml
@@ -17,7 +17,7 @@ classifiers = [
 ]
 
 [tool.poetry.dependencies]
-python = ">=3.8.1,<4.0"
+python = ">=3.9,<4.0"
 advocate = { version = ">=1.0.0,<2.0", optional = true }
 boto3 = ">=1.28.27"
 cassandra-driver = { version = ">=3.29.0,<4.0", optional = true }
@@ -112,4 +112,4 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.black]
 line-length = 100
-target-version = ['py38']
+target-version = ['py39']
diff --git a/setup.cfg b/setup.cfg
@@ -39,7 +39,7 @@ exclude =
     .eggs/
 
 [mypy]
-python_version = 3.8
+python_version = 3.9
 # https://opentelemetry.io/docs/instrumentation/python/mypy/
 namespace_packages = True
 warn_unused_configs = True