Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python3.8 support #1003

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Drop python3.8 support #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1668f7c
Drop python3.8 support
RyanBalfanz Oct 23, 2024
8b35839
`poetry lock`
RyanBalfanz Oct 23, 2024
fc75208
Set tool.black.target-version back to py38
RyanBalfanz Oct 23, 2024
75f8207
Disable too-many-positional-arguments
RyanBalfanz Oct 23, 2024
636668f
fix: Unused "type: ignore" comment
RyanBalfanz Oct 23, 2024
a0db156
Set tool.black.target-version to py39
RyanBalfanz Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12']

container:
image: python:${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion baseplate/frameworks/thrift/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def finalize_options(self) -> None:
self.set_undefined_options("build", ("build_base", "build_base"))

def run(self) -> None:
if self.dry_run: # type: ignore
if self.dry_run:
return

temp_dir = os.path.join(self.build_base, "thrift") # type: ignore
Expand Down
2 changes: 1 addition & 1 deletion docs/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ line-length = 74

# Always use our latest supported version here since we want code snippets in
# docs to use the most up-to-date syntax.
target-version = ['py38']
target-version = ['py39']
2,526 changes: 1,272 additions & 1,254 deletions poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ disable= attribute-defined-outside-init,
too-many-lines,
too-many-locals,
too-many-nested-blocks,
too-many-positional-arguments,
too-many-public-methods,
too-many-return-statements,
too-many-statements,
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ classifiers = [
]

[tool.poetry.dependencies]
python = ">=3.8.1,<4.0"
python = ">=3.9,<4.0"
advocate = { version = ">=1.0.0,<2.0", optional = true }
boto3 = ">=1.28.27"
cassandra-driver = { version = ">=3.29.0,<4.0", optional = true }
Expand Down Expand Up @@ -112,4 +112,4 @@ build-backend = "poetry.core.masonry.api"

[tool.black]
line-length = 100
target-version = ['py38']
target-version = ['py39']
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exclude =
.eggs/

[mypy]
python_version = 3.8
python_version = 3.9
# https://opentelemetry.io/docs/instrumentation/python/mypy/
namespace_packages = True
warn_unused_configs = True
Expand Down