[Migration Review - DO NOT MERGE] Service module #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
the
service
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
11 tasks
Olshansk
requested changes
Feb 13, 2024
|
|
||
| // the address capable of executing a MsgUpdateParams message. Typically, this | ||
| // should be the x/gov module account. | ||
| authority string | ||
|
|
||
| bankKeeper types.BankKeeper |
There was a problem hiding this comment.
Can we use ModuleInputs for this instead?
There was a problem hiding this comment.
I'm not sure I follow the question. ModuleInputs is being used, just in a higher scope. It's used in the context of the ProvideModule method in module.go.
|
|
||
| // DefaultApplicationModuleGenesisState generates a GenesisState object with a given number of applications. | ||
| // It returns the populated GenesisState object. | ||
| func DefaultApplicationModuleGenesisState(t *testing.T, n int) *apptypes.GenesisState { |
There was a problem hiding this comment.
Helpers have been temporarily removed to mitigate build failure while the migration is in progress. This will be reconciled at the end of the migration/base branch and reviewed in main..migration/review/base.
(cherry picked from commit a35acb4)
11 tasks
bryanchriswhite
commented
Feb 15, 2024
x/service/module/autocli.go
Outdated
| // AutoCLIOptions implements the autocli.HasAutoCLIConfig interface. | ||
| func (am AppModule) AutoCLIOptions() *autocliv1.ModuleOptions { | ||
| return &autocliv1.ModuleOptions{ | ||
| // TODO_TECHDEBT(#370): Integrate with AutoCLI |
There was a problem hiding this comment.
Commenting this out is not necessary and will confuse ignite upon future message scaffolding in this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Review branch for the session module migration to rollkit/cosmos-sdk v0.50.x (see: migration notion doc).
Once this branch is approved:
git diff origin/migration/service-module..origin/migration/review/service-moduleNOTE:
*.pulsar.gocode.proto/service/...,x/service/...) and dependencies.Issue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist