[Migration] Service module #365

bryanchriswhite · 2024-02-06T14:50:57Z

Summary

Human Summary

This branch applies the steps outlined in the migration guide notion doc under the "Module Bootstrapping > Service Module" section. To be merged after #372 has been approved.

Issue

[☂️ Tooling, Migration] Umbrella ticket for cosmos-sdk v0.50 migration #240

Type of change

Select one or more:

Testing

Run all unit tests: make go_develop_and_test
Run E2E tests locally: make test_e2e
Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

I have tested my changes using the available tooling
I have performed a self-review of my own code
I have commented my code, updated documentation and left TODOs throughout the codebase

x/service/keeper/service_test.go

x/service/module/autocli.go

x/service/keeper/service.go

x/service/module/module.go

x/service/module/tx.go

x/service/module/tx_add_service.go

x/service/module/tx_add_service_test.go

x/service/simulation/add_service.go

x/service/types/errors.go

x/service/types/genesis.go

x/service/types/genesis_test.go

x/service/types/message_add_service.go

x/service/types/message_add_service_test.go

x/service/types/msg_update_params.go

x/service/keeper/query_service_test.go

red-0ne

Great work!

Added some comments, mainly to discuss alignment and consistency with work done on other modules.

testutil/keeper/service.go

x/service/keeper/msg_update_params.go

x/service/keeper/query_service.go

x/service/module/autocli.go

x/service/types/errors.go

x/service/types/genesis_test.go

x/service/types/msg_update_params.go

bryanchriswhite added service Anything related to general-purpose RPC service support code health Cleans up some code labels Feb 6, 2024

bryanchriswhite self-assigned this Feb 6, 2024

bryanchriswhite force-pushed the migration/service-module branch 3 times, most recently from ce9e072 to 9727c64 Compare February 8, 2024 09:25

bryanchriswhite mentioned this pull request Feb 8, 2024

[Migration Review - DO NOT MERGE] Service module #372

Closed

11 tasks

bryanchriswhite added this to the Shannon TestNet milestone Feb 8, 2024

bryanchriswhite force-pushed the migration/service-module branch 3 times, most recently from fda5702 to c1fd8eb Compare February 9, 2024 03:32

bryanchriswhite mentioned this pull request Feb 12, 2024

[Migration] Base + modules #379

Closed

11 tasks

bryanchriswhite force-pushed the migration/service-module branch from c1fd8eb to f85c2c8 Compare February 12, 2024 07:49

bryanchriswhite added 17 commits February 12, 2024 10:17

scaffold: module service --params add_service_fee:uint --dep bank

3d462e3

scaffold: map service --no-message --module service name

288006b

refactor: move Service proto type to shared

e67e96b

reconcile: service proto type from main

11adb07

reconcile: module-level genesis_test

4f78c81

reconcile: module errors

267a132

reconcile: types genesis

e0c67ca

reconcile: types params

6ec382b

reconcile: types tests

d76ce27

reconcile: keeper tests

51758dd

scaffold: message add-service --module service --signer address

48420fa

reconcile: keeper base

441db64

refactor: rename scaffolded vars; no main analogue

bc746d3

reconcile: MsgAddServicer

de0343d

reconcile: x/service/keeper.msgServer#AddService()

60bd728

reconcile: x/service/keeper.msgServer#AddService() tests

9f65e95

reconcile: keeper testutils

f0499d5