[Migration] Gateway module #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
force-pushed
the
migration/gateway-module
branch
from
738ac92
to
6f74de9
Compare
red-0ne
added
gateway
red-0ne
requested review from
Olshansk and
bryanchriswhite
and removed request for
Olshansk and
bryanchriswhite
ignite scaffold module gateway --dep bank
ignite scaffold map gateway stake:coin --module gateway --no-message --index address --signer address
ignite scaffold message stake_gateway stake:coin --signer address --module gateway
ignite scaffold message unstake_gateway --signer address --module gateway
red-0ne
force-pushed
the
migration/gateway-module
branch
2 times, most recently
from
3b2c749
to
0807acd
Compare
red-0ne
force-pushed
the
migration/gateway-module
branch
from
0807acd
to
e3dc8e1
Compare
11 tasks
11 tasks
| Address: simAccount.Address.String(), | ||
| } | ||
|
|
||
| // TODO: Handling the UnstakeGateway simulation |
There was a problem hiding this comment.
(same as #371 (comment))
| @@ -0,0 +1 @@ | |||
| package types | |||
There was a problem hiding this comment.
Suggested change
| package types | |
| package types | |
| // This file is in place to declare the package for dynamically generated protobufs |
x/gateway/types/msg_update_params.go
Outdated
| // ValidateBasic does a sanity check on the provided data. | ||
| func (m *MsgUpdateParams) ValidateBasic() error { | ||
| if _, err := sdk.AccAddressFromBech32(m.Authority); err != nil { | ||
| return errorsmod.Wrap(err, "invalid authority address") |
There was a problem hiding this comment.
I think this should probably be a new gateway error type.
11 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Gatewaymodule migration based off ofmigration/base.Issue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist