ENH: Finalize migration of reporting interfaces #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
enh/54-migrating-reportlet-interfaces-2
branch
2 times, most recently
from
b91ff7c
to
7ea0b3a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 60.34% 64.70% +4.35%
==========================================
Files 20 23 +3
Lines 2242 2618 +376
Branches 399 422 +23
==========================================
+ Hits 1353 1694 +341
- Misses 795 812 +17
- Partials 94 112 +18 ☔ View full report in Codecov by Sentry. |
oesteban
force-pushed
the
enh/54-migrating-reportlet-interfaces-2
branch
from
7ea0b3a
to
fb79a20
Compare
oesteban
force-pushed
the
enh/54-migrating-reportlet-interfaces-2
branch
from
fb79a20
to
6846c70
Compare
oesteban
force-pushed
the
enh/54-migrating-reportlet-interfaces-2
branch
from
6846c70
to
4182979
Compare
oesteban
added a commit
that referenced
this pull request
May 25, 2023
This sidetracks #71 for interfaces with little discussion about whether they can be consider core enough to be maintained within NiReports. In addition, moves the SimpleBeforeAfter interface into the set of basic interfaces, as it is very often used.
oesteban
added a commit
that referenced
this pull request
May 25, 2023
This sidetracks #71 for interfaces with little discussion about whether they can be consider core enough to be maintained within NiReports. In addition, moves the SimpleBeforeAfter interface into the set of basic interfaces, as it is very often used.
mgxd
approved these changes
May 31, 2023
Co-authored-by: Mathias Goncalves <[email protected]>
effigies
force-pushed
the
enh/54-migrating-reportlet-interfaces-2
branch
from
8d197b5
to
70bfd85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings generalistic "reportlet capable" interfaces from niworkflows. It doesn't port those interfaces modified by niworkflows (e.g., the report-generating version of the normalization interface).
I'm a bit on the fence about this. Perhaps a cleaner way is to have a
nipreps.interfacesnamespace where packages can "contribute" their custom interfaces, where a set of default interfaces is available.This would be consistent with @mgxd's idea of
nipreps.synthstripand so forth.Also, splitting workflows and interfaces from niworkflows would probably be the best approach for clarity, and have niworkflows populate
nipreps.workflowsand nipreps-interfaces (or similar) populatenipreps.interfaces.What do you think?
Resolves: #54.