Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move SimpleShowMaskRPT from niworkflows #135

Closed
wants to merge 1 commit into from

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 4, 2024

sdcflows uses this interface but is producing warnings that niworkflows reporting has been moved to nireports. Making that more true.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (6404af3) to head (59cb904).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   60.34%   66.69%   +6.34%     
==========================================
  Files          20       21       +1     
  Lines        2242     2255      +13     
  Branches      399      399              
==========================================
+ Hits         1353     1504     +151     
+ Misses        795      643     -152     
- Partials       94      108      +14     
Flag Coverage Δ
unittests 66.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

effigies commented Oct 4, 2024

This is already done in #71. I've rebased that and will merge if it tests clean.

@effigies effigies closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant