ENH: Port basic report-capable interfaces from *NiWorkflows* #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAINT: Refactor structure of interfaces
DOC: Ensure copyright notice in all headers' comment
DOC: Ensure copyright notice in all headers' comment
ENH: Allow plotting of image rotated to cardinal axes
MAINT: Refactor structure of interfaces
ENH: Allow plotting of image rotated to cardinal axes
MAINT: Replace distutils use, upgrade versioneer
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 56.01% 55.13% -0.89%
==========================================
Files 19 20 +1
Lines 1828 1937 +109
Branches 369 381 +12
==========================================
+ Hits 1024 1068 +44
- Misses 728 795 +67
+ Partials 76 74 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This sidetracks #71 for interfaces with little discussion about whether they can be consider core enough to be maintained within NiReports. In addition, moves the SimpleBeforeAfter interface into the set of basic interfaces, as it is very often used.
oesteban
force-pushed
the
enh/add-simple-before-after
branch
from
c3f6b5d
to
60c7539
Compare
effigies
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sidetracks #71 for interfaces with little discussion about whether they can be consider core enough to be maintained within NiReports.
In addition, moves the SimpleBeforeAfter interface into the set of basic interfaces, as it is very often used.