Adding validation for aws credentials without any dependency on boto3 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the validation
joshuaberetta
changed the title
noliveleger
requested changes
Nov 11, 2020
noliveleger
requested changes
Nov 11, 2020
noliveleger
requested changes
Nov 11, 2020
noliveleger
requested changes
Nov 13, 2020
noliveleger
requested changes
Nov 13, 2020
# Conflicts: # helpers/config.py
…otoolbox/kobo-install into 125-validate-aws-credentials
noliveleger
requested changes
Nov 16, 2020
| if ( | ||
| self.access_key == 'test_access_key' | ||
| and self.secret_key == 'test_secret_key' | ||
| ): |
noliveleger
approved these changes
Nov 16, 2020
Bump version to 4.1.0
noliveleger
force-pushed
the
125-validate-aws-credentials
branch
from
54cb426
to
2ac9618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #125
Adding functionality to allow for AWS credentials to be validated during the setup process. If the validation fails for whatever reason, the user is prompted a maximum of another 2 times before being asked if they would like to rather skip the validation and continue with the setup. If validation is successful, they will be greeted with a
AWS credentials verifiedmessage and the setup process will continue as normal.