Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No checks if AWS credentials are entered or valid after selecting answering "yes" to "Do you want to use AWS S3 storage?" #125

Closed
joshuaberetta opened this issue Oct 8, 2020 · 3 comments · Fixed by #135
Assignees
Labels
enhancement New feature or request

Comments

@joshuaberetta
Copy link
Member

There are currently no checks if the credentials are entered or are valid after deciding to use AWS S3. I would image the that application will fail or have unexpected actions if this is the case. I'm currently unaware of an official way to verify credentials - perhaps an error should at least prompt the user within the web interface to re-enter correct or missing details? @noliveleger

def __questions_aws(self):

@noliveleger
Copy link
Contributor

@joshuaberetta, the idea of kobo-install is to be used right out of the box without any dependencies (at least in Linux, macOS requires one). We may need to use boto to test AWS credentials. Users should detect pretty quickly whether their AWS credentials are good or not. (e.g. Imports and Exports won't work)
We can block empty response though.

@noliveleger
Copy link
Contributor

@joshuaberetta, do you want to tackle this?

@joshuaberetta
Copy link
Member Author

Sure! @noliveleger

@joshuaberetta joshuaberetta self-assigned this Oct 14, 2020
@joshuaberetta joshuaberetta added the enhancement New feature or request label Oct 14, 2020
@noliveleger noliveleger added enhancement New feature or request and removed enhancement New feature or request labels Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants