Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding validation for aws credentials without any dependency on boto3 #135

Merged
merged 26 commits into from
Nov 16, 2020
Merged

Adding validation for aws credentials without any dependency on boto3 #135

merged 26 commits into from
Nov 16, 2020

Commits on Nov 10, 2020

  1. adding validation for aws credentials without any dependancy on boto3

    @joshuaberetta
    joshuaberetta committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    205535e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactoring' into 125-validate-aws-credentials

    @joshuaberetta
    joshuaberetta committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    65224ae View commit details
    Browse the repository at this point in the history

  3. Fixing flow and adding attempts remaining output

    @joshuaberetta
    joshuaberetta committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    205d0f4 View commit details
    Browse the repository at this point in the history

  4. returning False if not 200 status and not an error

    @joshuaberetta
    joshuaberetta committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    90b7139 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. pep8ing imports and method names

    @joshuaberetta
    joshuaberetta committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    a454a47 View commit details
    Browse the repository at this point in the history

  2. Adding option to skip aws validation in case something is going wrong… 

    … with the validation
    @joshuaberetta
    joshuaberetta committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    dbb823f View commit details
    Browse the repository at this point in the history

  3. minor edit

    @joshuaberetta
    joshuaberetta committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    d611262 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. addressing the minor requested changes

    @joshuaberetta
    joshuaberetta committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    01e66cd View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. refactoring validation question as requested to give user more control

    @joshuaberetta
    joshuaberetta committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    774b456 View commit details
    Browse the repository at this point in the history

  2. changing color of message to COLOR_SUCCESS when successfully validated

    @joshuaberetta
    joshuaberetta committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    60f09e2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactoring' into 125-validate-aws-credentials 

     # Conflicts:
 #	helpers/config.py
    @noliveleger
    noliveleger committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ffbea5e View commit details
    Browse the repository at this point in the history

  4. making requested changes

    @joshuaberetta
    joshuaberetta committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ad5468d View commit details
    Browse the repository at this point in the history

  5. Merge branch '125-validate-aws-credentials' of https://github.com/kob… 

    …otoolbox/kobo-install into 125-validate-aws-credentials
    @joshuaberetta
    joshuaberetta committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    56e1ecc View commit details
    Browse the repository at this point in the history

  6. minor refactoring

    @joshuaberetta
    joshuaberetta committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    eda83b7 View commit details
    Browse the repository at this point in the history

  7. fixing aws question ordering and adding unit tests for validation cases

    @joshuaberetta
    joshuaberetta committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    20d9476 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. splitting up tests to be more atomic

    @joshuaberetta
    joshuaberetta committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    9fff298 View commit details
    Browse the repository at this point in the history

  2. minor edit

    @joshuaberetta
    joshuaberetta committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    b5b8ee4 View commit details
    Browse the repository at this point in the history

  3. Dropped Python 2 support 

    Bump version to 4.1.0
    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    353d3ad View commit details
    Browse the repository at this point in the history

  4. Display disclaimer that Python2 is not supported anymore

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    6b087b3 View commit details
    Browse the repository at this point in the history

  5. Update README.md: Requirements 3.5 and up

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    db8aa80 View commit details
    Browse the repository at this point in the history

  6. Removed forgotten if-statement for Python2

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    f32f123 View commit details
    Browse the repository at this point in the history

  7. Fixed: exit setup when user chooses to overwrite kobo-env

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    a6af56a View commit details
    Browse the repository at this point in the history

  8. Removed forgotten __future__ imports

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    c620f94 View commit details
    Browse the repository at this point in the history

  9. Removed redundant utf-8 parameter for .encode() and .decode()

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    c89169d View commit details
    Browse the repository at this point in the history

  10. Bump version to 4.2.0

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    2ac9618 View commit details
    Browse the repository at this point in the history

  11. fixed tox env with py38

    @noliveleger
    noliveleger committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    b455868 View commit details
    Browse the repository at this point in the history