Add MQTT receiver #227
Add MQTT receiver #227
Conversation
|
|
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver
branch
7 times, most recently
from
1b1e213
to
92d508e
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver
branch
2 times, most recently
from
8294123
to
7e445a6
Compare
receivers/mqtt/mqtt.go
Outdated
| return false, fmt.Errorf("Failed to connect to MQTT broker: %w", token.Error()) | ||
| } | ||
|
|
||
| if token := n.client.Publish(n.settings.Topic, 0, false, string(msg)); token.Wait() && token.Error() != nil { |
There was a problem hiding this comment.
Publish accepts QoS and retained which are set to 0 and false here. I started adding them too, but I'll do separate PRs later, as the current PRs (to Grafana, alerting and the terraform provider) are becoming large.
| n.log.Error("Failed to template MQTT message", "error", tmplErr) | ||
| return "", fmt.Errorf("Failed to template MQTT message: %w", tmplErr) | ||
| } | ||
|
|
There was a problem hiding this comment.
we usually do not fail on errors caused by expanding templates. We log it as a warning and proceed. Let's keep the same logic here.
There was a problem hiding this comment.
Updated: 95ac686
| func (n *Notifier) Notify(ctx context.Context, as ...*types.Alert) (bool, error) { | ||
| n.log.Debug("Sending an MQTT message") | ||
|
|
||
| msg, err := n.buildMessage(ctx, as...) |
There was a problem hiding this comment.
although we validate Message while parsing config, it does not guarantee that it cannot be empty here. Should we check the result for emptiness?
It looks like MQTT does not put any requirements on this, though
There was a problem hiding this comment.
Yes, we can send even an empty message to a topic, not sure that we should check the result here.
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver
branch
from
084a220
to
29e10bb
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver
branch
from
29e10bb
to
88fb445
Compare
Adds an MQTT (v3.1) receiver.
Fixes grafana/grafana#16858
How to start an MQTT broker for testing
mosquitto can be used as a local MQTT broker for testing. Create the config file (full config file reference):
Start the server:
usernames and passwords
Install mosquitto for
mosquitto_passwdtool. Create the passwords file:Add the following to the
mosquitto.conf:Start the server:
Screenshots