Add TLS, QoS and retain options to the MQTT receiver #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
from
4982a99
to
bccfd21
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
from
bccfd21
to
454aa94
Compare
receivers/mqtt/config.go
Outdated
| Retain bool `json:"retain,omitempty" yaml:"retain,omitempty"` | ||
| TLSCACertificate string `json:"tlsCACertificate,omitempty" yaml:"tlsCACertificate,omitempty"` | ||
| TLSClientCertificate string `json:"tlsClientCertificate,omitempty" yaml:"tlsClientCertificate,omitempty"` | ||
| TLSClientKey string `json:"tlsClientKey,omitempty" yaml:"tlsClientKey,omitempty"` |
There was a problem hiding this comment.
It would be great if we group these fields into a struct (similar to what upstream does). This schema will let us group fields in UI as well.
There are some problems with nested secrets right now but it should be fixed in grafana/grafana#92035.
There was a problem hiding this comment.
Later we may reuse it in other integrations such as webhook
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
from
fd0c2cd
to
8fd94d3
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
from
8fd94d3
to
2a01a54
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
from
15d5b7b
to
aa46696
Compare
titolins
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Hey @alexander-akhmetov, hope I'm on time for a last comment here. I'm investigating how to inject TLS config in the webhook receiver and this could help a lot (in the scope of grafana/grafana#9548).
I could also tackle the suggested changes in a separate PR once you merge it, if you'd prefer 👍
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
3 times, most recently
from
ca50133
to
99614a5
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-receiver-certs
branch
from
99614a5
to
c2f1eec
Compare
alexander-akhmetov
deleted the
alexander-akhmetov/mqtt-receiver-certs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TLS, QoS and Retain parameters to the MQTT receiver.
Grafana PR: grafana/grafana#92331
Related: grafana/grafana#16858 and #227