MQTT receiver: Add a setting to append group key to the topic name #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| n.log.Error("Failed to extract group key", "error", err.Error()) | ||
| return false, fmt.Errorf("Failed to extract group key: %s", err.Error()) | ||
| } | ||
| topic = path.Join(n.settings.Topic, string(groupKey)) |
There was a problem hiding this comment.
there are couple of edge cases that I think we should take care of:
- Let's trim
/at the ends, and replace all occurrences with-or_. - Same about wildcards:
+and# - MQTT puts restriction on length of the topic, up to 65535. Perhaps it makes sense to check it
There was a problem hiding this comment.
the format of group key is like {parent_matchers[/child_matchers]+}:{group_labels} . I wonder what you think if we unwrap the matchers brackets and the topic will resemble the routing tree like.
.../parent_matchers/child_matcher/child_matcher/group_key
alexander-akhmetov
force-pushed
the
alexander-akhmetov/mqtt-append-group-key-to-topic
branch
from
103ab89
to
568bc2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new setting,
AddGroupKeyToTopic. If true, appends the group key to the topic name.Grafana PR: grafana/grafana#92618
Related: grafana/grafana#16858 and #227