forked from apiaryio/dredd-hooks-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Semantic Versioning #3
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
02b0e11
Add Gemfile.lock
gonzalo-bulnes 815a942
Workaround broken test suite
gonzalo-bulnes 80c26f2
Workaround DreddHooks::Server leftover by test suite
gonzalo-bulnes 3dbc490
Move to semantic versioning
gonzalo-bulnes 234f499
Update CHANGELOG
gonzalo-bulnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
/.bundle/ | ||
/.yardoc | ||
/Gemfile.lock | ||
/_yardoc/ | ||
/coverage/ | ||
/doc/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
PATH | ||
remote: . | ||
specs: | ||
dredd_hooks (0.1.0) | ||
|
||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
aruba (0.6.2) | ||
childprocess (>= 0.3.6) | ||
cucumber (>= 1.1.1) | ||
rspec-expectations (>= 2.7.0) | ||
builder (3.2.2) | ||
childprocess (0.5.9) | ||
ffi (~> 1.0, >= 1.0.11) | ||
cucumber (2.3.3) | ||
builder (>= 2.1.2) | ||
cucumber-core (~> 1.4.0) | ||
cucumber-wire (~> 0.0.1) | ||
diff-lcs (>= 1.1.3) | ||
gherkin (~> 3.2.0) | ||
multi_json (>= 1.7.5, < 2.0) | ||
multi_test (>= 0.1.2) | ||
cucumber-core (1.4.0) | ||
gherkin (~> 3.2.0) | ||
cucumber-wire (0.0.1) | ||
diff-lcs (1.2.5) | ||
ffi (1.9.10) | ||
gherkin (3.2.0) | ||
multi_json (1.11.2) | ||
multi_test (0.1.2) | ||
rack (1.6.4) | ||
rack-protection (1.5.3) | ||
rack | ||
rake (10.5.0) | ||
rspec-expectations (3.4.0) | ||
diff-lcs (>= 1.2.0, < 2.0) | ||
rspec-support (~> 3.4.0) | ||
rspec-support (3.4.1) | ||
sinatra (1.4.7) | ||
rack (~> 1.5) | ||
rack-protection (~> 1.4) | ||
tilt (>= 1.3, < 3) | ||
tilt (2.0.2) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
aruba (~> 0.6.2) | ||
bundler (~> 1.6) | ||
dredd_hooks! | ||
rake (~> 10.0) | ||
sinatra (~> 1.4.5) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module DreddHooks | ||
VERSION = "0.0.1" | ||
VERSION = "0.1.0" | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did git bisect the broken test suite (
bundle exec cucumber
) down to 8dc3e26 and confirmed that this step is causing the error described in the commit message.Removing it is not a fix, as it supposes to remove the TCP server Cucumber feature. Most of the feature is quite low-level however, and I think that the benefits of a working test suite outweigh the cost.
I'll try to find a better way to test the default host and port of the Dredd hooks server (it is part of the API that Dredd expects to be available).