Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Semantic Versioning #3

Merged
merged 5 commits into from
May 2, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/.bundle/
/.yardoc
/Gemfile.lock
/_yardoc/
/coverage/
/doc/
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).

- Started using the Semantic Versioning convention

### Fixed

- The test suite can be used locally (it is a workaround only)

## 0.0.1 - 2015-07-07

### Added
Expand Down
54 changes: 54 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
PATH
remote: .
specs:
dredd_hooks (0.1.0)

GEM
remote: https://rubygems.org/
specs:
aruba (0.6.2)
childprocess (>= 0.3.6)
cucumber (>= 1.1.1)
rspec-expectations (>= 2.7.0)
builder (3.2.2)
childprocess (0.5.9)
ffi (~> 1.0, >= 1.0.11)
cucumber (2.3.3)
builder (>= 2.1.2)
cucumber-core (~> 1.4.0)
cucumber-wire (~> 0.0.1)
diff-lcs (>= 1.1.3)
gherkin (~> 3.2.0)
multi_json (>= 1.7.5, < 2.0)
multi_test (>= 0.1.2)
cucumber-core (1.4.0)
gherkin (~> 3.2.0)
cucumber-wire (0.0.1)
diff-lcs (1.2.5)
ffi (1.9.10)
gherkin (3.2.0)
multi_json (1.11.2)
multi_test (0.1.2)
rack (1.6.4)
rack-protection (1.5.3)
rack
rake (10.5.0)
rspec-expectations (3.4.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.4.0)
rspec-support (3.4.1)
sinatra (1.4.7)
rack (~> 1.5)
rack-protection (~> 1.4)
tilt (>= 1.3, < 3)
tilt (2.0.2)

PLATFORMS
ruby

DEPENDENCIES
aruba (~> 0.6.2)
bundler (~> 1.6)
dredd_hooks!
rake (~> 10.0)
sinatra (~> 1.4.5)
14 changes: 4 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,13 @@ Test your api with [Dredd HTTP API testing framework](https://github.com/apiaryi

## Installation

Add this line to your application's Gemfile:
Add the gem to your `Gemfile`:

```ruby
gem 'dredd_hooks'
```

And then execute:

$ bundle
# Gemfile

Or install it yourself as:

$ gem install dredd_hooks
gem 'dredd_hooks', '0.1.0' # see semver.org
```

## Usage

Expand Down
5 changes: 1 addition & 4 deletions features/support/env.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
Before do
puts "Killing server..."
system "for i in `ps axu | grep 'server.rb' | grep ruby | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1"
puts "Killing handler..."
system "for i in `ps axu | grep 'dredd-hooks' | grep ruby | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1"
sleep 3

Copy link
Owner Author

@gonzalo-bulnes gonzalo-bulnes May 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did git bisect the broken test suite (bundle exec cucumber) down to 8dc3e26 and confirmed that this step is causing the error described in the commit message.

Removing it is not a fix, as it supposes to remove the TCP server Cucumber feature. Most of the feature is quite low-level however, and I think that the benefits of a working test suite outweigh the cost.

I'll try to find a better way to test the default host and port of the Dredd hooks server (it is part of the API that Dredd expects to be available).

@aruba_timeout_seconds = 10
end
end
66 changes: 0 additions & 66 deletions features/tcp_server.feature

This file was deleted.

2 changes: 1 addition & 1 deletion lib/dredd_hooks/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module DreddHooks
VERSION = "0.0.1"
VERSION = "0.1.0"
end