Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Semantic Versioning #3

Merged
merged 5 commits into from
May 2, 2016
Merged

Move to Semantic Versioning #3

merged 5 commits into from
May 2, 2016

Commits on Apr 24, 2016

  1. Add Gemfile.lock 

    This file SHOULD NOT be ignored, because it is the only way to
ensure the bundle consitency accross different repositories.

It should never be edited by hand either, and any change to the
Gemfile or gemspec should be committed with the corresponding
Gemfile.lock - run 'bundle install' to update the lock.
    @gonzalo-bulnes
    gonzalo-bulnes committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    02b0e11 View commit details
    Browse the repository at this point in the history

  2. Workaround broken test suite 

    The 'bundle exec rake' command did fail with message:

    $ bundle exec rake
    Feature: Execution order

    Killed: 9

I suspect that the error was shadowed because the Gemfile.lock was missing,
but I am not sure exactly why. (Travis seems to be using the new
'features/support/env.rb and still doing fine.)

Anyway, the error is present in my development env. since 8dc3e26
and appeared in Travis CI when I added the Gemfile.lock.

See https://travis-ci.org/gonzalo-bulnes/dredd-hooks-ruby/jobs/125324433

This commit partially reverts 8dc3e26
    @gonzalo-bulnes
    gonzalo-bulnes committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    815a942 View commit details
    Browse the repository at this point in the history

  3. Workaround DreddHooks::Server leftover by test suite 

    The TCP Server feature starts a server but doesn't stop it.
This breaks the next test suite run unless the server is manually
killed, which is unpractical.

I think it's best to remove the entire feature until findinf a proper
fix to this issue and 7330c74
    @gonzalo-bulnes
    gonzalo-bulnes committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    80c26f2 View commit details
    Browse the repository at this point in the history

  4. Move to semantic versioning 

    Bump version number
Minor remove excessive installation details

Installing gems manually ('gem install dredd_hooks') is always possible,
however, if you who needs it to be mentionned in the README, you are
probably not familar with Ruby and should use a Gemfile.
    @gonzalo-bulnes
    gonzalo-bulnes committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    3dbc490 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG

    @gonzalo-bulnes
    gonzalo-bulnes committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    234f499 View commit details
    Browse the repository at this point in the history