Move to Semantic Versioning #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file SHOULD NOT be ignored, because it is the only way to ensure the bundle consitency accross different repositories. It should never be edited by hand either, and any change to the Gemfile or gemspec should be committed with the corresponding Gemfile.lock - run 'bundle install' to update the lock.
The 'bundle exec rake' command did fail with message:
$ bundle exec rake
Feature: Execution order
Killed: 9
I suspect that the error was shadowed because the Gemfile.lock was missing,
but I am not sure exactly why. (Travis seems to be using the new
'features/support/env.rb and still doing fine.)
Anyway, the error is present in my development env. since 8dc3e26
and appeared in Travis CI when I added the Gemfile.lock.
See https://travis-ci.org/gonzalo-bulnes/dredd-hooks-ruby/jobs/125324433
This commit partially reverts 8dc3e26
The TCP Server feature starts a server but doesn't stop it. This breaks the next test suite run unless the server is manually killed, which is unpractical. I think it's best to remove the entire feature until findinf a proper fix to this issue and 7330c74
Bump version number
Minor remove excessive installation details
Installing gems manually ('gem install dredd_hooks') is always possible,
however, if you who needs it to be mentionned in the README, you are
probably not familar with Ruby and should use a Gemfile.
| @@ -4,9 +4,6 @@ | |||
| Before do | |||
| puts "Killing server..." | |||
| system "for i in `ps axu | grep 'server.rb' | grep ruby | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1" | |||
| puts "Killing handler..." | |||
There was a problem hiding this comment.
I did git bisect the broken test suite (bundle exec cucumber) down to 8dc3e26 and confirmed that this step is causing the error described in the commit message.
Removing it is not a fix, as it supposes to remove the TCP server Cucumber feature. Most of the feature is quite low-level however, and I think that the benefits of a working test suite outweigh the cost.
I'll try to find a better way to test the default host and port of the Dredd hooks server (it is part of the API that Dredd expects to be available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer
In order to be able to update my dependencies automatically
And to be sure their maintainers care about their API
I want their version numbers to convey meaning
See apiaryio#5