[6.0] Test failures on OSX: OSVersion_ValidVersion_OSX, CurrencyNegativePattern_Get_ReturnsExpected_ByLocale #80252

CarnaViire · 2023-01-05T18:41:32Z

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=125170
Build error leg or test failing: System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX, System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")
Pull request: #79549, #80190, #80209

Failing Configurations (3)

net6.0-OSX-Debug-x64-CoreCLR_checked-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-Mono_release-OSX.1200.Amd64.Open

Related/potential cause: #80030

Error Message

System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX

Exception Message

Assert.Contains() Failure
Not found: 12.4
In value:  osx.11.1-x64

CallStack

   at System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX() in /_/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs:line 193

System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")

Exception Message

Assert.Contains() Failure
Not found: 12
In value:  Int32[] [1]

Stack Trace

   at System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(String locale) in /_/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyNegativePattern.cs:line 56

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

The text was updated successfully, but these errors were encountered:

dotnet-issue-labeler · 2023-01-05T18:41:35Z

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost · 2023-01-05T18:43:41Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=125170
Build error leg or test failing: System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX, System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")
Pull request: #79549, #80190, #80209

Failing Configurations (3)

net6.0-OSX-Debug-x64-CoreCLR_checked-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-Mono_release-OSX.1200.Amd64.Open

Related/potential cause: #80030

Error Message

System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX

Exception Message

Assert.Contains() Failure
Not found: 12.4
In value:  osx.11.1-x64

CallStack

   at System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX() in /_/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs:line 193

System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")

Exception Message

Assert.Contains() Failure
Not found: 12
In value:  Int32[] [1]

Stack Trace

   at System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(String locale) in /_/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyNegativePattern.cs:line 56

Author:	CarnaViire
Assignees:	-
Labels:	`blocking-clean-ci`, `area-Infrastructure`, `untriaged`, `Known Build Error`
Milestone:	-

ghost · 2023-01-11T01:10:36Z

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=125170
Build error leg or test failing: System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX, System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")
Pull request: #79549, #80190, #80209

Failing Configurations (3)

net6.0-OSX-Debug-x64-CoreCLR_checked-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-Mono_release-OSX.1200.Amd64.Open

Related/potential cause: #80030

Error Message

System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX

Exception Message

Assert.Contains() Failure
Not found: 12.4
In value:  osx.11.1-x64

CallStack

   at System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX() in /_/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs:line 193

System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")

Exception Message

Assert.Contains() Failure
Not found: 12
In value:  Int32[] [1]

Stack Trace

   at System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(String locale) in /_/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyNegativePattern.cs:line 56

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

Author:	CarnaViire
Assignees:	-
Labels:	`area-System.Globalization`, `os-mac-os-x`, `blocking-clean-ci`, `untriaged`, `Known Build Error`
Milestone:	-

carlossanlop · 2023-01-11T01:11:47Z

Here's an example of a failing test happening in the internal->public merge PR for 6.0:

PR: https://github.com/dotnet/runtime/pull/80452/checks?check_run_id=10562386944
Job result: https://dev.azure.com/dnceng-public/public/_build/results?buildId=132447&view=logs&j=c6f8dc49-92a1-5760-c098-ba97b8142bfb&t=5d5289b6-723b-5155-5d15-b590d280a14a&l=60
Callstacks of the two failing tests: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-80452-merge-0a7bcaf1408544f1a2/System.Globalization.Tests/1/console.d1046adc.log?helixlogtype=result
The failure is happening here in the System.Globalization test:

runtime/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyNegativePattern.cs

Line 56 in fb31012

Assert.Contains(format.CurrencyNegativePattern, NumberFormatInfoData.GetCurrencyNegativePatterns(locale));
The failure is happening here in the System.Runtime test:

runtime/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

Line 193 in fb31012

Assert.Contains(version.ToString(2), RuntimeInformation.RuntimeIdentifier);

tarekgh · 2023-01-11T01:43:34Z

@carlossanlop this looks to me the OS detection is the culprit here and not the test itself. This may explain the other Environment test failure which is same.
Can you send more details about the version of the OSX running the test? I tagged the issue as System.Runtime because this is not the globalization issue.

ghost · 2023-01-11T01:46:10Z

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=125170
Build error leg or test failing: System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX, System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")
Pull request: #79549, #80190, #80209

Failing Configurations (3)

net6.0-OSX-Debug-x64-CoreCLR_checked-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-CoreCLR_release-OSX.1200.Amd64.Open
net6.0-OSX-Debug-x64-Mono_release-OSX.1200.Amd64.Open

Related/potential cause: #80030

Error Message

System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX

Exception Message

Assert.Contains() Failure
Not found: 12.4
In value:  osx.11.1-x64

CallStack

   at System.Tests.EnvironmentTests.OSVersion_ValidVersion_OSX() in /_/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs:line 193

System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(locale: \"es-BO\")

Exception Message

Assert.Contains() Failure
Not found: 12
In value:  Int32[] [1]

Stack Trace

   at System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern.CurrencyNegativePattern_Get_ReturnsExpected_ByLocale(String locale) in /_/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyNegativePattern.cs:line 56

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

Author:	CarnaViire
Assignees:	-
Labels:	`area-System.Runtime`, `os-mac-os-x`, `blocking-clean-ci`, `untriaged`, `Known Build Error`
Milestone:	-

ViktorHofer · 2023-01-11T14:02:30Z

I agree with Tarek that this needs to be investigated, ideally before next servicing release's code-complete, as the failures might indicate a product regression.

tarekgh · 2023-01-11T15:17:33Z

#44120

akoeplinger · 2023-01-11T15:38:58Z

The OSVersion_ValidVersion_OSX test isn't that concerning, it's just a test issue regarding how the version is checked.

The CurrencyNegativePattern_Get_ReturnsExpected_ByLocale was fixed by #63971 so we'd need to backport that to 6.0

tarekgh · 2023-01-11T16:07:41Z

@akoeplinger looks you are right. I was looking at the main branch code and not 6.0 release. Any idea why EnvironmentTest is failing too?

I can port the globalization test fix to 6.0.

akoeplinger · 2023-01-12T15:39:07Z

@tarekgh I see we're at least missing this change to the test from this commit in 6.0 which makes it only look at the major version: 5da4464#diff-3b1296c3b8a733ad1c027de7b5c653d0843afcc959cf9b2656160a9dcf8c0aa5R193-R194

But that doesn't explain the full story since we're still getting 12 from Environment.OSVersion vs. 11 from RuntimeInformation.RuntimeIdentifier.

akoeplinger · 2023-01-12T16:28:37Z

I figured it out, will send a PR. I'll include the globalization fix in that.

akoeplinger · 2023-01-12T16:39:12Z

#80560

tarekgh · 2023-01-13T17:19:09Z

Fixed by #80560

CarnaViire added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Jan 5, 2023

ghost added the untriaged New issue has not been triaged by the area owner label Jan 5, 2023

CarnaViire added the area-Infrastructure label Jan 5, 2023

CarnaViire added the os-mac-os-x macOS aka OSX label Jan 5, 2023

runfoapp bot mentioned this issue Jan 5, 2023

Infrastructure - Status/Health #702

Closed

carlossanlop added area-System.Globalization and removed area-Infrastructure labels Jan 11, 2023

carlossanlop mentioned this issue Jan 11, 2023

Merging internal commits for release/6.0 #80452

Merged

tarekgh added area-System.Runtime and removed area-System.Globalization labels Jan 11, 2023

carlossanlop mentioned this issue Jan 11, 2023

[release/6.0] fix for generation info in GCMemoryInfo #80417

Merged

This was referenced Jan 11, 2023

[release/6.0] Backport FileStream finalization fixes #80439

Merged

[release/6.0] Don't upgrade homebrew packages in CI #80455

Merged

[6.0] Disable GetProviderNames_AssertProperties test #80512

Merged

akoeplinger mentioned this issue Jan 12, 2023

[release/6.0] Update dotnet host for testing and fix failing globalization test #80560

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 12, 2023

carlossanlop mentioned this issue Jan 12, 2023

[release/6.0] Invalidate buffered data when bypassing the cache #80554

Merged

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 12, 2023

tarekgh closed this as completed Jan 13, 2023

ghost removed the untriaged New issue has not been triaged by the area owner label Jan 13, 2023

ghost locked as resolved and limited conversation to collaborators Feb 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[6.0] Test failures on OSX: OSVersion_ValidVersion_OSX, CurrencyNegativePattern_Get_ReturnsExpected_ByLocale #80252

[6.0] Test failures on OSX: OSVersion_ValidVersion_OSX, CurrencyNegativePattern_Get_ReturnsExpected_ByLocale #80252

CarnaViire commented Jan 5, 2023 •

edited by build-analysis bot

Loading

dotnet-issue-labeler bot commented Jan 5, 2023

ghost commented Jan 5, 2023

Build Information

Error Message

ghost commented Jan 11, 2023

Build Information

Error Message

Report

Summary

carlossanlop commented Jan 11, 2023 •

edited

Loading

tarekgh commented Jan 11, 2023 •

edited

Loading

ghost commented Jan 11, 2023

Build Information

Error Message

Report

Summary

ViktorHofer commented Jan 11, 2023 •

edited

Loading

tarekgh commented Jan 11, 2023

akoeplinger commented Jan 11, 2023

tarekgh commented Jan 11, 2023

akoeplinger commented Jan 12, 2023 •

edited

Loading

akoeplinger commented Jan 12, 2023

akoeplinger commented Jan 12, 2023

tarekgh commented Jan 13, 2023

[6.0] Test failures on OSX: OSVersion_ValidVersion_OSX, CurrencyNegativePattern_Get_ReturnsExpected_ByLocale #80252

[6.0] Test failures on OSX: OSVersion_ValidVersion_OSX, CurrencyNegativePattern_Get_ReturnsExpected_ByLocale #80252

Comments

CarnaViire commented Jan 5, 2023 • edited by build-analysis bot Loading

Build Information

Error Message

Report

Summary

dotnet-issue-labeler bot commented Jan 5, 2023

ghost commented Jan 5, 2023

Build Information

Error Message

ghost commented Jan 11, 2023

Build Information

Error Message

Report

Summary

carlossanlop commented Jan 11, 2023 • edited Loading

tarekgh commented Jan 11, 2023 • edited Loading

ghost commented Jan 11, 2023

Build Information

Error Message

Report

Summary

ViktorHofer commented Jan 11, 2023 • edited Loading

tarekgh commented Jan 11, 2023

akoeplinger commented Jan 11, 2023

tarekgh commented Jan 11, 2023

akoeplinger commented Jan 12, 2023 • edited Loading

akoeplinger commented Jan 12, 2023

akoeplinger commented Jan 12, 2023

tarekgh commented Jan 13, 2023

CarnaViire commented Jan 5, 2023 •

edited by build-analysis bot

Loading

carlossanlop commented Jan 11, 2023 •

edited

Loading

tarekgh commented Jan 11, 2023 •

edited

Loading

ViktorHofer commented Jan 11, 2023 •

edited

Loading

akoeplinger commented Jan 12, 2023 •

edited

Loading