-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Update dotnet host for testing and fix failing globalization test #80560
Conversation
…rsion_OSX We changed how we got the OS version in dotnet@f30e7fa to account for the macOS versioning changes. The `dotnet` host used for testing was still on a version before that change so the RID it set (which flows through to RuntimeInformation.RuntimeIdentifier) was using the old format. Updating to the latest 6.0.13 fixes that. Also bring in the change from dotnet@5da4464#diff-3b1296c3b8a733ad1c027de7b5c653d0843afcc959cf9b2656160a9dcf8c0aa5R193-R194 so we only check for the major OS version.
(cherry picked from commit b7d8f5e)
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsWe changed how we got the OS version in f30e7fa to account for the macOS versioning changes. The This also backports #63971 which is necessary to fix a globalization test on macOS 12.
|
@carlossanlop this is a test/CI-only change so I think we don't need approval right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akoeplinger for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for fixing this, @akoeplinger.
Yes, it's tell mode, no approval needed. I'll merge when the CI finishes. |
CI failures are unrelated.
Ready to merge. |
We changed how we got the OS version in f30e7fa to account for the macOS versioning changes.
The
dotnet
host used for testing was still on a version before that change so the RID it set (which flows through toRuntimeInformation.RuntimeIdentifier
) was using the old format.Updating to the latest 6.0.13 and adding the change from 5da4464 so we only check for the major OS version fixes the OSVersion_ValidVersion_OSX test.
This also backports #63971 which is necessary to fix a globalization test on macOS 12.
Fixes #80252