Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0][Android] Fix SslStream on legacy Android API levels #79277

Conversation

simonrozsival
Copy link
Member

@simonrozsival simonrozsival commented Dec 6, 2022

Backport of #78849 and #78918 to release/6.0

/cc @steveisok
Supersedes #79039

Customer Impact

These fixes address issues reported by our customers (#78715, #78716) when using SocketsHttpHandler
.NET declares support for Android API versions 21+ and these changes fix the SslStream class on API 21-26.

Testing

  • CI tests (API 29)
  • local testing on Android emulators (API 21, 24, 26, 33) and device (API 31)

Risk

Low.

@ghost
Copy link

ghost commented Dec 6, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78849 and #78918 to release/6.0

/cc @steveisok
Supersedes #79039

Customer Impact

These fixes address issues reported by our customers (#78715, #78716).
.NET declares support for Android API versions 21+ and these changes fix the SslStream class on API 21-26.

Testing

  • CI tests (API 29)
  • local testing on Android emulators (API 21, 24, 26, 33) and device (API 31)

Risk

Low.

Author: simonrozsival
Assignees: simonrozsival
Labels:

area-System.Net.Security

Milestone: -

@steveisok steveisok added the Servicing-consider Issue for next servicing release review label Dec 6, 2022
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 6, 2022
@rbhanda rbhanda added this to the 6.0.14 milestone Dec 6, 2022
@ghost
Copy link

ghost commented Dec 13, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78849 and #78918 to release/6.0

/cc @steveisok
Supersedes #79039

Customer Impact

These fixes address issues reported by our customers (#78715, #78716) when using SocketsHttpHandler
.NET declares support for Android API versions 21+ and these changes fix the SslStream class on API 21-26.

Testing

  • CI tests (API 29)
  • local testing on Android emulators (API 21, 24, 26, 33) and device (API 31)

Risk

Low.

Author: simonrozsival
Assignees: simonrozsival
Labels:

Servicing-approved, area-System.Net.Security, os-android

Milestone: 6.0.14

@carlossanlop
Copy link
Member

@simonrozsival can you please get a code review sign-off? Also, can you please investigate the CI results and determine if they are related or not?

@simonrozsival
Copy link
Member Author

/azp run runtime,runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@simonrozsival
Copy link
Member Author

CI test failures are unrelated to this PR.

@carlossanlop
Copy link
Member

Approved by Tactics (6.0.14).
Signed off by area owner.
No OOB changes needed (Android).
CI failures are unrelated: dotnet/winforms#8829 and #80252
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 7fe0f1d into dotnet:release/6.0 Jan 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants