Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] fix for generation info in GCMemoryInfo #80417

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 10, 2023

Backport of #60309 to release/6.0

/cc @mangod9 @Maoni0

Customer Impact

Corrupt info returned when calling GCMemoryInfo. The fix has been made to 7 and needs to be backported to 6.0

Testing

This has been validated by customers in 7.0. The fix is simple (resetting memory)

Risk

Low risk fix. Just a memset.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Jan 10, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #60309 to release/6.0

/cc @mangod9 @Maoni0

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 6.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Jan 10, 2023
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 10, 2023
@leecow leecow modified the milestones: 6.0.x, 6.0.14 Jan 10, 2023
@carlossanlop
Copy link
Member

Approved by Tactics (6.0.14).
Got a trifecta of code review sign-offs.
No OOB changes needed (coreclr native code).
CI failures are unrelated: #80476 and #80252
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 31322b2 into release/6.0 Jan 11, 2023
@carlossanlop carlossanlop deleted the backport/pr-60309-to-release/6.0 branch January 11, 2023 02:16
@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-GC-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants