Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repo): Correctly handle publint/attw errors [SDK-908] #2124

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore(repo): Correctly handle publint/attw errors [SDK-908] #2124

merged 1 commit into from
Nov 14, 2023
+99 −48

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Nov 13, 2023 •
edited
Loading

Description

There are a number of "workable issues" output by publint and attw. This PR does the following:

  • Splits out the problematic packages into different CI steps
  • The non-problematic packages will correctly error if an issue arises.
  • The remaining packages are still run with continue-on-error, for the time being.

Additional Minor Updates:

  • Patch Turborepo (1.10.15 -> 1.10.16): Corrects minor caching issues.
  • Add *.tgz (created by attw task) to .gitignore: I believe this, under the right circumstances, causes cache invalidations.
  • Remove unused test:ci task.

SDK-908

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski tmilewski self-assigned this Nov 13, 2023
@tmilewski tmilewski requested a review from a team as a code owner November 13, 2023 17:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ed1c7e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tmilewski tmilewski changed the title chore(repo): Handle publint errors [SDK-908] chore(repo): Correctly handle publint/attw errors [SDK-908] Nov 13, 2023
@tmilewski tmilewski force-pushed the sdk-908-publint-no-continue-on-failure branch from d153b0c to 65ab5fa Compare November 13, 2023 17:59
@tmilewski tmilewski force-pushed the sdk-908-publint-no-continue-on-failure branch 4 times, most recently from d6835c4 to 35913aa Compare November 13, 2023 18:15
@tmilewski tmilewski force-pushed the sdk-908-publint-no-continue-on-failure branch from 35913aa to ed1c7e1 Compare November 13, 2023 18:31
@tmilewski tmilewski added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit b986c4c Nov 14, 2023
6 checks passed
@tmilewski tmilewski deleted the sdk-908-publint-no-continue-on-failure branch November 14, 2023 08:24
dimkl
dimkl reviewed Nov 14, 2023
View reviewed changes
.gitignore
scripts/.env
!scripts/.env.example


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 ✂️ empty line

dimkl
dimkl reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tmilewski added a commit that referenced this pull request Nov 14, 2023
@tmilewski
chore(repo): Handle publint/attw errors [SDK-908] (#2124)
98e677b 
(cherry picked from commit b986c4c)
@tmilewski tmilewski mentioned this pull request Nov 14, 2023
Merged
24 tasks
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2023
@tmilewski
chore(repo): Handle publint/attw errors [SDK-908] (#2124) (#2131)
60d08a0 
* chore(repo): Handle publint/attw errors [SDK-908] (#2124)

(cherry picked from commit b986c4c)

* chore(repo): Target release/v4 in require changeset step
@LekoArts LekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArts LekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkl dimkl dimkl left review comments

@LekoArts LekoArts LekoArts approved these changes

Assignees

@tmilewski tmilewski

Labels
actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmilewski @dimkl @LekoArts @clerk-cookie