Skip to content

Commit

Permalink
chore(repo): Handle publint/attw errors [SDK-908] (#2124)
Browse files Browse the repository at this point in the history
(cherry picked from commit b986c4c)
  • Loading branch information
tmilewski committed Nov 14, 2023
1 parent 221a684 commit 98e677b
Show file tree
Hide file tree
Showing 5 changed files with 111 additions and 60 deletions.
23 changes: 11 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,6 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Test Envs
run: |
echo "TURBO_ARGS: $TURBO_ARGS"
echo "TURBO_TEAM: $TURBO_TEAM"
echo "TURBO_TOKEN: $TURBO_TOKEN"
echo "TURBO_REMOTE_ONLY: $TURBO_REMOTE_ONLY"
echo "TURBO_REMOTE_CACHE_SIGNATURE_KEY: $TURBO_REMOTE_CACHE_SIGNATURE_KEY"
echo "FORCE_COLOR: $FORCE_COLOR"
- name: Require Changeset
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
if: ${{ !(github.event_name == 'merge_group') }}
Expand All @@ -59,17 +50,25 @@ jobs:

- name: Lint packages using publint
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npm run lint:publint -- $TURBO_ARGS
run: npx turbo lint:publint $TURBO_ARGS --filter=!@clerk/clerk-js

- name: Lint packages using publint [Errors Allowed]
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npx turbo lint:publint $TURBO_ARGS --filter=@clerk/clerk-js --continue
continue-on-error: true # TODO: Remove this when all related errors are fixed

- name: Lint types using attw
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npm run lint:attw -- $TURBO_ARGS
run: npx turbo lint:attw --filter=!@clerk/clerk-sdk-node --filter=!@clerk/nextjs --filter=!@clerk/clerk-react --filter=!@clerk/shared

- name: Lint types using attw [Errors Allowed]
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npx turbo lint:attw --filter=@clerk/clerk-sdk-node --filter=@clerk/nextjs --filter=@clerk/clerk-react --filter=@clerk/shared --continue
continue-on-error: true # TODO: Remove this when all related errors are fixed

- name: Run lint
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npm run lint -- $TURBO_ARGS -- --quiet
run: npx turbo lint $TURBO_ARGS -- --quiet

- name: Upload Turbo Summary
uses: actions/upload-artifact@v3
Expand Down
8 changes: 7 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,14 @@ playground/*/yarn.lock
playwright-report
test-results

# verdaccio
# Verdaccio
.verdaccio

# Workflow Outputs
/packages/*/*.tgz

# Scripts
scripts/.env
!scripts/.env.example


117 changes: 92 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"tree-kill": "^1.2.2",
"ts-jest": "^29.0.3",
"tsup": "^7.2.0",
"turbo": "^1.10.15",
"turbo": "^1.10.16",
"typescript": "^5.2.2",
"verdaccio": "^5.26.3",
"zx": "^7.2.3"
Expand Down
21 changes: 0 additions & 21 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,27 +78,6 @@
"test:cache:clear": {
"cache": false
},
"test:ci": {
"dependsOn": ["build"],
"inputs": [
"*.d.ts",
"**/package.json",
"bundlewatch.config.json",
"jest.*",
"src/**",
"tests/**",
"tsconfig.json",
"tsconfig.*.json",
"tsup.config.ts",

"!**/__snapshots__/**",
"!coverage/**",
"!examples/**",
"!node_modules/**"
],
"outputMode": "new-only",
"outputs": []
},
"lint": {
"dependsOn": ["^build"],
"outputs": []
Expand Down

0 comments on commit 98e677b

Please sign in to comment.