Skip to content

Commit

Permalink
chore(repo): Handle publint/attw errors [SDK-908]
Browse files Browse the repository at this point in the history
  • Loading branch information
tmilewski committed Nov 13, 2023
1 parent 4509da5 commit 65ab5fa
Show file tree
Hide file tree
Showing 6 changed files with 101 additions and 51 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:
branches:
- main
- release/v4
- ci-updates

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -35,7 +34,6 @@ jobs:
id: config
uses: ./.github/actions/init
with:
turbo-remote-only: false
turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
turbo-team: ${{ vars.TURBO_TEAM }}
Expand All @@ -61,17 +59,25 @@ jobs:

- name: Lint packages using publint
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npm run lint:publint -- $TURBO_ARGS
run: npx turbo lint:publint $TURBO_ARGS --filter=!@clerk/clerk-js

- name: Lint packages using publint [Errors Allowed]
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npx turbo lint:publint $TURBO_ARGS --filter=@clerk/clerk-js --continue
continue-on-error: true # TODO: Remove this when all related errors are fixed

- name: Lint types using attw
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npm run lint:attw -- $TURBO_ARGS
run: npx turbo lint:attw --filter=@clerk/clerk-sdk-node --filter=!@clerk/nextjs --filter=!@clerk/clerk-react

- name: Lint types using attw [Errors Allowed]
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npx turbo lint:attw --filter=@clerk/clerk-sdk-node --filter=@clerk/nextjs --filter=@clerk/clerk-react --continue
continue-on-error: true # TODO: Remove this when all related errors are fixed

- name: Run lint
timeout-minutes: ${{ fromJSON(vars.TIMEOUT_MINUTES_SHORT) }}
run: npm run lint -- $TURBO_ARGS -- --quiet
run: npx turbo lint $TURBO_ARGS -- --quiet

- name: Upload Turbo Summary
uses: actions/upload-artifact@v3
Expand Down
8 changes: 7 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,14 @@ playground/*/yarn.lock
playwright-report
test-results

# verdaccio
# Verdaccio
.verdaccio

# Workflow Outputs
/packages/*/*.tgz

# Scripts
scripts/.env
!scripts/.env.example


92 changes: 80 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"tree-kill": "^1.2.2",
"ts-jest": "^29.0.3",
"tsup": "^7.2.0",
"turbo": "^1.10.15",
"turbo": "^1.10.16",
"typescript": "^5.2.2",
"verdaccio": "^5.26.3",
"zx": "^7.2.3"
Expand Down
1 change: 1 addition & 0 deletions packages/sdk-node/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": ["//"],
"pipeline": {
"build": {
"env": ["CLERK_*"],
"inputs": [
"*.d.ts",
"**/package.json",
Expand Down
33 changes: 1 addition & 32 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,7 @@
"signature": true
},
"globalDependencies": ["jest.*.ts", "package.json", "package-lock.json", "tsconfig.json", "tsconfig.*.json"],
"globalEnv": [
"CLERK_*",
"GATSBY_CLERK_*",
"NEXT_PUBLIC_CLERK_*",
"MAILSAC_API_KEY",
"NODE_ENV",
"NODE_VERSION",
"NPM_VERSION",
"TZ",
"VERCEL"
],
"globalEnv": ["NODE_ENV", "NODE_VERSION", "NPM_VERSION", "TZ", "VERCEL"],
"pipeline": {
"build": {
"dependsOn": ["^build"],
Expand Down Expand Up @@ -78,27 +68,6 @@
"test:cache:clear": {
"cache": false
},
"test:ci": {
"dependsOn": ["build"],
"inputs": [
"*.d.ts",
"**/package.json",
"bundlewatch.config.json",
"jest.*",
"src/**",
"tests/**",
"tsconfig.json",
"tsconfig.*.json",
"tsup.config.ts",

"!**/__snapshots__/**",
"!coverage/**",
"!examples/**",
"!node_modules/**"
],
"outputMode": "new-only",
"outputs": []
},
"lint": {
"dependsOn": ["^build"],
"outputs": []
Expand Down

0 comments on commit 65ab5fa

Please sign in to comment.