chore(deps): bump @xmldom/xmldom from 0.8.10 to 0.9.0; run [DynamicXml] #10481
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@xmldom/[email protected]) |
chris48s
changed the title
|
@dependabot rebase |
Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.8.10 to 0.9.0. - [Release notes](https://github.com/xmldom/xmldom/releases) - [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md) - [Commits](xmldom/xmldom@0.8.10...0.9.0) --- updated-dependencies: - dependency-name: "@xmldom/xmldom" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/xmldom/xmldom-0.9.0
branch
from
ebc0166
to
c4d7785
Compare
|
| const parsed = new DOMParser().parseFromString(buffer) | ||
| const parsed = new DOMParser().parseFromString(buffer, 'text/xml') |
There was a problem hiding this comment.
Notes on breaking change:
https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md#fixed-27
In principle, this might be breaking if any users were using the dynamic xml badge to try and parse HTML documents (which may or may not have worked). One thing we could do here is try and decide whether we should pass text/html here based on the filename or response headers. I think my instinct on this is to just hard-code text/xml here, deploy it, and see if anyone pops up demanding we re-enable spacebar heating
|
I'm going to leave this one open for a bit before I merge it, just in case anyone wants to chime in on this. |
|
A newer version of @xmldom/xmldom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Right. I'm going to go ahead and merge this then let dependabot bump us to 0.9.2. It will probably be quicker than editing this |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Bumps @xmldom/xmldom from 0.8.10 to 0.9.0.
Release notes
Sourced from
@xmldom/xmldom's releases.... (truncated)
Changelog
Sourced from
@xmldom/xmldom's changelog.... (truncated)
Commits
8c7c7af0.9.00e7afbbdocs: prepare 0.9.0 (#709)ade64e1chore(deps-dev): bump axios from 1.6.0 to 1.7.5 (#707)2f598ebchore(deps): update github/codeql-action action to v3.26.5 (#706)bccf286chore(deps): update github/codeql-action action to v3.26.4 (#704)87fbb1fchore(deps): update actions/upload-artifact action to v4.3.6 (#703)3f14422chore(deps): update dependency eslint-plugin-n to v17.10.2 (#700)94a0e11chore(deps): update step-security/harden-runner action to v2.9.1 (#702)03e53b1chore(deps): update actions/upload-artifact action to v4.3.5 (#701)4254b32chore(deps): update dependency eslint-plugin-n to v17.10.0 (#699)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)