catch xml ParseError in [DynamicXml] badge #10516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we deployed #10481
and a few of these popped up
https://shields.sentry.io/issues/5811374190
#10481 (comment)
This is not a completely new source of error. For example
https://shields.sentry.io/issues/4386982653
has been happening occasionally for a while.
I'm not really sure exactly what input triggers either of those and we might still end up making further changes following #10481 (comment)
but fundamentally, a document that doesn't parse shouldn't be an unhandled error on an endpoint where we accept arbitrary input. So lets fix that.