Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump @xmldom/xmldom from 0.8.10 to 0.9.0; run [DynamicXml] #10481

Merged
merged 2 commits into from
Sep 7, 2024
Merged

chore(deps): bump @xmldom/xmldom from 0.8.10 to 0.9.0; run [DynamicXml] #10481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4d7785
chore(deps): bump @xmldom/xmldom from 0.8.10 to 0.9.0
dependabot[bot] Sep 2, 2024
d212df5
invoke parseFromString with mimetype
chris48s Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@renovatebot/ruby-semver": "^3.0.23",
"@sentry/node": "^8.26.0",
"@shields_io/camp": "^18.1.2",
"@xmldom/xmldom": "0.8.10",
"@xmldom/xmldom": "0.9.0",
"badge-maker": "file:badge-maker",
"bytes": "^3.1.2",
"camelcase": "^8.0.0",
Expand Down
2 changes: 1 addition & 1 deletion services/dynamic/dynamic-xml.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default class DynamicXml extends BaseService {
const pathIsAttr = (
pathExpression.split('/').slice(-1)[0] || ''
).startsWith('@')
const parsed = new DOMParser().parseFromString(buffer)
const parsed = new DOMParser().parseFromString(buffer, 'text/xml')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes on breaking change:
https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md#fixed-27
In principle, this might be breaking if any users were using the dynamic xml badge to try and parse HTML documents (which may or may not have worked). One thing we could do here is try and decide whether we should pass text/html here based on the filename or response headers. I think my instinct on this is to just hard-code text/xml here, deploy it, and see if anyone pops up demanding we re-enable spacebar heating

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.


let values
try {
Expand Down
Loading