Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP-1259: Fix bug in GraphicScene API #244

Merged
merged 4 commits into from
Oct 10, 2024
Merged

BP-1259: Fix bug in GraphicScene API #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b911bc
Fix breakage to GraphicScene API
andreparames Oct 10, 2024
383cb35
Update tree.py
andreparames Oct 10, 2024
32e3164
Remove too loud of a warning
andreparames Oct 10, 2024
dc7eabc
Remove obsolete import
andreparames Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions dal/data/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"""
from abc import ABC, abstractmethod
from collections import OrderedDict
from typing import Dict, Generic, List, Mapping, Optional, Tuple, TypeVar, Union
from typing import Dict, Generic, List, Optional, Tuple, TypeVar, Union
from dal.data.mixins import ChildrenCmpMixin, ValueCmpMixin


Expand Down Expand Up @@ -143,9 +143,6 @@ def count(self) -> int:
number of children
"""

def __len__(self):
return self.count

@property
@abstractmethod
def path(self):
Expand Down Expand Up @@ -239,7 +236,7 @@ def remove_child(self, node: VT):
node._parent = None


class DictNode(TreeNode[VT], ChildrenCmpMixin, Mapping[str, VT]):
class DictNode(TreeNode[VT], ChildrenCmpMixin):
"""
Implements a dict tree node
"""
Expand Down
3 changes: 0 additions & 3 deletions dal/movaidb/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,9 +822,6 @@ def validate(
keys.append(key_val)

def dict_to_keys(self, _input: dict, validate=None):
if validate is not None:
LOGGER.warning("Parameter 'validate' of dict_to_keys() is deprecated")

# Keys is a list of tuples with (key, value, source)
keys: List[Tuple[str, Any, Any]] = list() # careful with class variables...
self.validate(_input, self.api_struct, "", keys)
Expand Down
Loading