Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-1259: Fix bug in GraphicScene API #244

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

andreparames
Copy link
Contributor

@andreparames andreparames commented Oct 10, 2024

Adding the __len__ caused Python to change its behavior when the code tests the truthiness of the object (as in, if obj:).

Also cleaning up a warning that was way too verbose.

TIcket: BP-1259

  • Make sure you are opening from a topic/feature/bugfix branch
  • Ensure that the PR title represents the desired changes
  • Ensure that the PR description detail the desired changes
  • Link to relevant issues in GitHub or Jira

@andreparames andreparames self-assigned this Oct 10, 2024
@andreparames andreparames changed the title BP-1259: FIx bug in GraphicScene API BP-1259: Fix bug in GraphicScene API Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@duartecoelhomovai duartecoelhomovai merged commit 03f439b into releases/2.5.0 Oct 10, 2024
7 checks passed
@duartecoelhomovai duartecoelhomovai deleted the bugfix/BP-1259/fix-bug branch October 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants