Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(aria_hidden_nontabbable) improve group message #1506

Merged
merged 11 commits into from
Jun 29, 2023

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Jun 22, 2023

Rule/Engine updates:

fixrule(ruleid): improve group msg in rule and baselines

This PR is related to the following issue(s):

Additional information can be found here:

  • ruleID was changed to aria_hidden_nontabbable during ruleID consistency work:
    message:
    "group": "A focusable element should not be within the subtree of an element with 'aria-hidden' set to \"true\"",
    changed to:
    "group": "A hidden element should not contain any tabbable elements",
  • "group" message is displayed in Help, not in test files, so no changes are needed in test cases
  • "group" message changed in rule and baselines files

Testing reference:

  • regular build testing
    test/v2/checker/accessibility/rules/aria_hidden_notabbale_ruleunit/*

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins changed the title improve group msg in rule and baselines fixrule(aria_hidden_nontabbable) improve group message Jun 22, 2023
@philljenkins philljenkins linked an issue Jun 22, 2023 that may be closed by this pull request
@philljenkins philljenkins marked this pull request as ready for review June 22, 2023 22:01
shunguoy
shunguoy previously approved these changes Jun 23, 2023
@philljenkins
Copy link
Contributor Author

@shunguoy Why shouldn't the baseline files be checked in?
such as ...accessibility-checker/test/baselines/baslines.verify.toolkit.json

26c8641

@ErickRenteria ErickRenteria merged commit 0d3448a into master Jun 29, 2023
13 checks passed
@shunguoy shunguoy deleted the phill-aria-hidden-focus-misuse-1395 branch August 11, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixrule(aria_hidden_nontabbable) improve group mesage
3 participants