Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixrule(aria_hidden_nontabbable) improve group message #1506

Merged
merged 11 commits into from
Jun 29, 2023
Merged

fixrule(aria_hidden_nontabbable) improve group message #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
60d93cd
improve group msg in rule and baselines
philljenkins Jun 22, 2023
c54db58
Merge branch 'master' into phill-aria-hidden-focus-misuse-1395
philljenkins Jun 22, 2023
dfae95a
Merge branch 'master' into phill-aria-hidden-focus-misuse-1395
ErickRenteria Jun 26, 2023
c72d81c
Merge branch 'master' into phill-aria-hidden-focus-misuse-1395
ErickRenteria Jun 29, 2023
692023c
Merge branch 'master' into phill-aria-hidden-focus-misuse-1395
shunguoy Jun 29, 2023
08efce0
Delete settings.json
shunguoy Jun 29, 2023
57b6698
the file shouldn't be checked in.
shunguoy Jun 29, 2023
64f2611
the file shouldn't be checked in.
shunguoy Jun 29, 2023
18257d8
the file shouldn't be checked in.
shunguoy Jun 29, 2023
13ab089
the file shouldn't be checked in.
shunguoy Jun 29, 2023
26c8641
the file shouldn't be checked in.
shunguoy Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions .vscode/settings.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/aria_hidden_nontabbable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export let aria_hidden_nontabbable: Rule = {
},
messages: {
"en-US": {
"group": "A focusable element should not be within the subtree of an element with 'aria-hidden' set to \"true\"",
"group": "A hidden element should not contain any tabbable elements",
"Pass_0": "Rule Passed",
"Fail_1": "Element \"{0}\" should not be focusable within the subtree of an element with an 'aria-hidden' attribute with value 'true'"
}
Expand Down
Loading