Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(aria_hidden_nontabbable) improve group mesage #1395

Closed
philljenkins opened this issue Apr 13, 2023 · 5 comments · Fixed by #1506
Closed

fixrule(aria_hidden_nontabbable) improve group mesage #1395

philljenkins opened this issue Apr 13, 2023 · 5 comments · Fixed by #1506
Assignees
Labels
engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA SME Discuss with subject matter experts

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Apr 13, 2023

Reword group message:

"group": "A focusable element should not be within the subtree of an element with 'aria-hidden' set to \"true\"",

to
"group": "A hidden element should not contain any tabbable elements",

as discussed during ruleID consistency review

existing ruleID.ts file containing message
https://github.com/IBMa/equal-access/blob/master/accessibility-checker-engine/src/v4/rules/aria_hidden_focus_misuse.ts

@philljenkins philljenkins added engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts priority-2 (med) labels Apr 13, 2023
@philljenkins philljenkins self-assigned this Jun 21, 2023
@philljenkins philljenkins changed the title fix(aria_hidden_focus_misuse) improve mesage fixrule(aria_hidden_focus_misuse) improve group mesage Jun 22, 2023
@philljenkins
Copy link
Contributor Author

philljenkins commented Jun 22, 2023

ruleID was changed to aria_hidden_nontabbable during ruleID consistency work:
"group": "A focusable element should not be within the subtree of an element with 'aria-hidden' set to \"true\"",
change to
"group": "A hidden element should not contain any tabbable elements",

  • "group" message is displayed in Help, not in test files, so no changes are needed in test cases.
  • "group" message changed in rule and baselines files

@philljenkins philljenkins changed the title fixrule(aria_hidden_focus_misuse) improve group mesage fixrule( aria_hidden_nontabbable) improve group mesage Jun 22, 2023
@philljenkins philljenkins changed the title fixrule( aria_hidden_nontabbable) improve group mesage fixrule(aria_hidden_nontabbable) improve group mesage Jun 22, 2023
@philljenkins philljenkins linked a pull request Jun 22, 2023 that will close this issue
8 tasks
@philljenkins
Copy link
Contributor Author

philljenkins commented Jun 22, 2023

PR #1506 assigned to @shunguoy for review

@philljenkins
Copy link
Contributor Author

This is a screenshot of the "old" group message displayed in the Help
image

@philljenkins
Copy link
Contributor Author

philljenkins commented Jun 29, 2023

The new build will show the group message replaced by the new message
The "group" message is the lighter title after the Violation in the banner
New group message is: "A hidden element should not contain any tabbable elements"

@ErickRenteria
Copy link
Contributor

ErickRenteria commented Jun 29, 2023

Screen Shot 2023-06-29 at 4 00 29 PM Validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA SME Discuss with subject matter experts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants