Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nan validation #184

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix Nan validation #184

merged 1 commit into from
Jul 12, 2023

Conversation

matthewelwell
Copy link
Contributor

Fixes #183.

@matthewelwell matthewelwell linked an issue Jul 11, 2023 that may be closed by this pull request
Unable to identify user with a trait that has the value "Nan" #183
Closed
4 tasks
@github-actions
Copy link

File Coverage
All files 100% ✅

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against fbb958b

@khvn26 khvn26 self-requested a review July 11, 2023 18:38
khvn26
khvn26 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct

@matthewelwell matthewelwell merged commit 1f4c50e into main Jul 12, 2023
4 checks passed
@matthewelwell matthewelwell deleted the fix/183/unable-to-identify-user-with-a-trait-that-has-the-value-nan branch July 12, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 approved these changes

@gagantrivedi gagantrivedi gagantrivedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to identify user with a trait that has the value "Nan"
3 participants
@matthewelwell @khvn26 @gagantrivedi