Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nan validation #184

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix Nan validation #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flag_engine/identities/traits/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
from typing import Union

from pydantic import constr
from pydantic.types import confloat, constr

from flag_engine.identities.traits.constants import TRAIT_STRING_VALUE_MAX_LENGTH

TraitValue = Union[
None,
float,
confloat(allow_inf_nan=False),
int,
bool,
constr(max_length=TRAIT_STRING_VALUE_MAX_LENGTH),
Expand Down
15 changes: 15 additions & 0 deletions tests/unit/identities/test_identities_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,18 @@ def test_trait_model__deserialize__expected_trait_value(
# Then
assert isinstance(result.trait_value, type(expected_result))
assert result.trait_value == expected_result


def test_identity_model__deserialize__handles_nan():
# When
result = IdentityModel.parse_obj(
{
"identifier": "identity",
"environment_api_key": "api-key",
"identity_traits": [{"trait_key": "nan_trait", "trait_value": "Nan"}],
}
)

# Then
assert result
assert result.identity_traits[0].trait_value == "Nan"