Fix Nan validation (#184)

Flagsmith · Jul 12, 2023 · 1f4c50e · 1f4c50e
1 parent 75d0c18
commit 1f4c50e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/flag_engine/identities/traits/types.py b/flag_engine/identities/traits/types.py
@@ -1,12 +1,12 @@
 from typing import Union
 
-from pydantic import constr
+from pydantic.types import confloat, constr
 
 from flag_engine.identities.traits.constants import TRAIT_STRING_VALUE_MAX_LENGTH
 
 TraitValue = Union[
     None,
-    float,
+    confloat(allow_inf_nan=False),
     int,
     bool,
     constr(max_length=TRAIT_STRING_VALUE_MAX_LENGTH),

diff --git a/tests/unit/identities/test_identities_models.py b/tests/unit/identities/test_identities_models.py
@@ -202,3 +202,18 @@ def test_trait_model__deserialize__expected_trait_value(
     # Then
     assert isinstance(result.trait_value, type(expected_result))
     assert result.trait_value == expected_result
+
+
+def test_identity_model__deserialize__handles_nan():
+    # When
+    result = IdentityModel.parse_obj(
+        {
+            "identifier": "identity",
+            "environment_api_key": "api-key",
+            "identity_traits": [{"trait_key": "nan_trait", "trait_value": "Nan"}],
+        }
+    )
+
+    # Then
+    assert result
+    assert result.identity_traits[0].trait_value == "Nan"