Simulation enhancement #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
InvincibleRMC
requested changes
Sep 18, 2024
| start_gazebo = ExecuteProcess( | ||
| cmd=['ign', 'gazebo', '-v', '3', '-r', world_path], output='screen' | ||
| ) | ||
| start_gazebo = ExecuteProcess(cmd=['gz', 'sim', '-v', '3', '-r', world_path], output='screen') |
There was a problem hiding this comment.
Did you check out gz_sim launch?
There was a problem hiding this comment.
Hmm I didn't know this existed but it looks pretty nice
https://index.ros.org/p/ros_gz_sim/
|
also remove xacro dep |
benjaminwp18
requested changes
Sep 21, 2024
…/rov-25 into simulation-enhancement
for more information, see https://pre-commit.ci
InvincibleRMC
approved these changes
Oct 5, 2024
Signed-off-by: Michael Carlstrom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of PR is this? (check all applicable)
Description
Update simulation to GZ Sim Harmonic and improve simulation model and environment
Related Tickets & Documents