zcash_client_backend: Move change memos into the ChangeValue components of Proposals
#1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
nuttycom
force-pushed
the
wallet/proposal_change_memos
branch
from
b964e64
to
ad7117e
Compare
daira
reviewed
Oct 11, 2023
daira
reviewed
Oct 11, 2023
daira
reviewed
Oct 11, 2023
daira
reviewed
Oct 11, 2023
daira
reviewed
Oct 11, 2023
nuttycom
force-pushed
the
wallet/proposal_change_memos
branch
from
5ef8687
to
f5b5849
Compare
|
The wasi and clippy failures were due to failed downloads from crates.io, so I restarted them. |
nuttycom
force-pushed
the
wallet/proposal_change_memos
branch
from
f5b5849
to
73421ec
Compare
…ents of `Proposal`s. The existing API limited change outputs to having only a single memo repeated across each change output. This change makes it so that each proposed change output can have its own associated memo, and leaves it up to the input selector to determine how requested change memos are associated with change outputs.
Co-authored-by: Daira Emma Hopwood <[email protected]>
nuttycom
force-pushed
the
wallet/proposal_change_memos
branch
from
73421ec
to
bcea060
Compare
|
force-pushed to resolve conflicts after the merge of #1013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing API limited change outputs to having only a single memo repeated across each change output. This change makes it so that each proposed change output can have its own associated memo, and leaves it up to the input selector to determine how requested change memos are associated with change outputs.