Apply suggestions from code review

Co-authored-by: Daira Emma Hopwood <[email protected]>
zcash · Oct 11, 2023 · 5ef8687 · 5ef8687
1 parent ad7117e
commit 5ef8687
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/zcash_client_backend/src/fees.rs b/zcash_client_backend/src/fees.rs
@@ -36,6 +36,12 @@ impl ChangeValue {
             ChangeValue::Sapling { value, .. } => *value,
         }
     }
+    pub fn memo(&self) -> MemoBytes {
+        match self {
+            ChangeValue::Sapling { memo, .. } =>
+                memo.as_ref().map_or_else(MemoBytes::empty, |m| m.clone())
+        }
+    }
 }
 
 /// The amount of change and fees required to make a transaction's inputs and

diff --git a/zcash_client_backend/src/fees/fixed.rs b/zcash_client_backend/src/fees/fixed.rs
@@ -26,7 +26,8 @@ pub struct SingleOutputChangeStrategy {
 }
 
 impl SingleOutputChangeStrategy {
-    /// Constructs a new [`SingleOutputChangeStrategy`] with the specified fee rule.
+    /// Constructs a new [`SingleOutputChangeStrategy`] with the specified fee rule
+    /// and change memo.
     pub fn new(fee_rule: FixedFeeRule, change_memo: Option<MemoBytes>) -> Self {
         Self {
             fee_rule,

diff --git a/zcash_client_backend/src/fees/zip317.rs b/zcash_client_backend/src/fees/zip317.rs
@@ -34,7 +34,7 @@ pub struct SingleOutputChangeStrategy {
 
 impl SingleOutputChangeStrategy {
     /// Constructs a new [`SingleOutputChangeStrategy`] with the specified ZIP 317
-    /// fee parameters.
+    /// fee parameters and change memo.
     pub fn new(fee_rule: Zip317FeeRule, change_memo: Option<MemoBytes>) -> Self {
         Self {
             fee_rule,