Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CHYT init options into makeDefault and createPublicClique #347

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

achulkov2
Copy link
Collaborator

@achulkov2 achulkov2 commented Sep 19, 2024

Currently, the makeDefault parameter in the CHYT spec has two meanings. First, it adds --make-default to the init script parameters, which causes the uploaded image to be marked as default for cliques. Second, it controls whether initChPublicJob is run. These effects are completely unrelated and one does not always want both of them. This PR moves the second effect under its own option createPublicClique.

@achulkov2
Copy link
Collaborator Author

achulkov2 commented Sep 19, 2024

I did not rename makeDefault because it would require renaming things in ytsaurus as well, which is a nuisance from a backwards compatibility perspective (operator can be used with a lot of different versions of ytsaurus images). I do agree that its name is rather ambiguous as well, maybe we should rename it (probably sometime later).

api/v1/chyt_types.go Outdated Show resolved Hide resolved
@l0kix2 l0kix2 merged commit c439d7c into main Sep 19, 2024
5 checks passed
@l0kix2 l0kix2 deleted the members/achulkov2/separate-chyt-init-options branch September 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants