Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHYT resource should separate setting new version as default from creating the default ch_public clique #312

Closed
achulkov2 opened this issue Jul 16, 2024 · 1 comment
Closed

CHYT resource should separate setting new version as default from creating the default ch_public clique #312

achulkov2 opened this issue Jul 16, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@achulkov2
Copy link
Collaborator

Right now the makeDefault: true setting in the CHYT resource leads to the new binary being set as the default CH version, as well as the creation of the default ch_public clique.
These should be two separate options, as the latter might mess up the ch_public clique configuration if it already exists.
@achulkov2 achulkov2 added the good first issue Good for newcomers label Jul 16, 2024
@l0kix2
Copy link
Collaborator

l0kix2 commented Oct 9, 2024

I guess this is fixed here #347
@achulkov2 reopen please if i'm wrong

@l0kix2 l0kix2 closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
yt-k8s-operator project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l0kix2 @achulkov2