-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support underscore delimiter for yeti UDIM textures #129
Support underscore delimiter for yeti UDIM textures #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me.
Tested with ornatrix rig. The changes does not affect the publish.
@LiborBatek can you do the test on Yeti?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not work for me (did try 2 times and also built the ayon-maya addon for the second try) gives validation errors (enclosing the JSON file too)
And the full JSON log:
Thanks @LiborBatek can you show me the udim files on disk? |
Actually - I think I've found it. For whatever reason my filename tested did have more than one dot in the filename so it passed another check. I think I may have fixed your case with b882f60 Any chance it's easy for you to try again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog Description
Correctly collect sequences with
_1001.exr
instead of only delimited by.
like.1001.exr
.Additional info
Fixes #117
This same function is also used for collecting Ornatrix textures - so it may be worth running a check of publishing ornatrix textures along as well.
Testing notes:
_
delimiter, like:C:/projects/ayontest/asset/char_hero/publish/image/textureMain.Diffuse/v002/ynts_char_hero_textureMain.Diffuse_v002_<UDIM>.png