Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting texture maps with cliique assemble after the update of the bug fix on the UDIM context data #18

Closed
moonyuet opened this issue Jul 11, 2024 · 1 comment

Comments

@moonyuet
Copy link
Member

          **Not crucial for this PR, but something to consider over time?**

This may actually fail for published UDIM files from Substance Painter integration with the default template because the UDIM tile I believe is separated by _ instead of . so there will still only ever be one dot in the filename.

As such, I wonder. Do we still need the len(filename.split(".")) > 2 check?

Beware that _1001.exr may not be picked up by the clique.assemble call either with the "frames" pattern because I believe that may also require a dot as number separator. So allowing publish/v001/udim/texture_1001.exr may require more fixes than just removing that if statement check. :)

Originally posted by @BigRoy in #1 (comment)

@moonyuet moonyuet changed the title **Not crucial for this PR, but something to consider over time?** Collecting texture maps with cliique assemble after the update of the bug fix on the UDIM context data Jul 11, 2024
@BigRoy
Copy link
Contributor

BigRoy commented Oct 7, 2024

This has been fixed with #129

@BigRoy BigRoy closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants