Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revome override buttons in ActionColumn::class #128

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Revome override buttons in ActionColumn::class #128

merged 1 commit into from
Aug 20, 2023

Conversation

g-rodigy
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #124

@what-the-diff
Copy link

what-the-diff bot commented Aug 20, 2023

PR Summary

  • Implementation of Button Defaults
    A safeguard has been introduced that ensures standard buttons are utilized when no specific buttons are chosen. This improvement was implemented in the ActionColumn.php file.

  • Elimination of a Method Call
    The method call to createDefaultButtons() in the GridView.php file has been removed. This simplifies the file's operations, reducing unnecessary system processing and heightening overall performance.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9d44f77) 100.00% compared to head (7f7d499) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #128   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       469       470    +1     
===========================================
  Files             19        19           
  Lines           1558      1559    +1     
===========================================
+ Hits            1558      1559    +1     
Files Changed Coverage Δ
src/GridView.php 100.00% <ø> (ø)
src/Column/ActionColumn.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw linked an issue Aug 20, 2023 that may be closed by this pull request
@terabytesoftw
Copy link
Member

Ready ?

@terabytesoftw terabytesoftw merged commit 90895a9 into yiisoft:master Aug 20, 2023
10 of 11 checks passed
@g-rodigy g-rodigy deleted the fix-custom-buttons branch September 4, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't override default buttons for GridView
2 participants