Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't override default buttons for GridView #124

Closed
kratkar opened this issue Aug 16, 2023 · 2 comments · Fixed by #128
Closed

Can't override default buttons for GridView #124

kratkar opened this issue Aug 16, 2023 · 2 comments · Fixed by #128

Comments

@kratkar
Copy link

kratkar commented Aug 16, 2023

What steps will reproduce the problem?

I add ActionColumn with action 'delete'

But... Default buttons replacements my

yii-dataview/src/GridView.php

Line 354 in 2c668d4

->createDefaultButtons()

'createDefaultButtons' unnecessary

Additional info

Q A
Version 3
PHP version 8.2
@samdark
Copy link
Member

samdark commented Aug 18, 2023

Do you know how to fix that? Should it be merged?

@kratkar
Copy link
Author

kratkar commented Aug 18, 2023

There are many solutions. I removed that line. If necessary, you can call createDefaultButtons.

@g-rodigy g-rodigy mentioned this issue Aug 20, 2023
Merged
@terabytesoftw terabytesoftw linked a pull request Aug 20, 2023 that will close this issue
Revome override buttons in ActionColumn::class #128
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revome override buttons in ActionColumn::class
2 participants
@samdark @kratkar