Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to distill/pretty print values #496

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Make it easier to distill/pretty print values #496

merged 4 commits into from
Feb 9, 2023

Commits on Feb 9, 2023

  1. Make it easier to distill/pretty print values 

    This reduces the gymnasics we’ve needed to do whenever we want to pretty
print something by cloning the name environment as opposed to taking it
by mutable reference when constructing a distillation environment.

This means we can no longer reuse the existing allocation when
temporarily pushing local names, but I think the savings we got from
this was probably minor, and the increase in clarity is worth it.
    @brendanzab
    brendanzab committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    dab98d9 View commit details
    Browse the repository at this point in the history

  2. Tidy up name suggestions 

    Breaks up the long, vertical method chain into some separate
definitions, and tweaks the field names in the related messages for
clarity.
    @brendanzab
    brendanzab committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    5cb0a2a View commit details
    Browse the repository at this point in the history

  3. Import cleanups

    @brendanzab
    brendanzab committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    6a33a47 View commit details
    Browse the repository at this point in the history

  4. More cleanups to diagnostic reporting 

    Some of this was probably unlocked by the switch to a global string
interner.
    @brendanzab
    brendanzab committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    817cc41 View commit details
    Browse the repository at this point in the history