Make it easier to distill/pretty print values #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzab
force-pushed
the
distillation-cleanups
branch
from
d9a0246
to
8446cb2
Compare
This reduces the gymnasics we’ve needed to do whenever we want to pretty print something by cloning the name environment as opposed to taking it by mutable reference when constructing a distillation environment. This means we can no longer reuse the existing allocation when temporarily pushing local names, but I think the savings we got from this was probably minor, and the increase in clarity is worth it.
brendanzab
force-pushed
the
distillation-cleanups
branch
from
c920aba
to
9ed1c4a
Compare
Breaks up the long, vertical method chain into some separate definitions, and tweaks the field names in the related messages for clarity.
brendanzab
force-pushed
the
distillation-cleanups
branch
from
e5c858b
to
6a33a47
Compare
Some of this was probably unlocked by the switch to a global string interner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to address #488, this reduces some of the gymnasics we’ve needed to do whenever we want to pretty print something. We achieve this by cloning the name environment as opposed to taking it by mutable reference when constructing a distillation environment.
This means we can no longer reuse the existing allocation when temporarily pushing local names, but I think the savings we got from this was probably minor, and the increase in clarity is worth it.