Improve Driver Disks handling as Supplemental Packs #73
Conversation
In interactive mode, when Driver Disks are used as local media, they must *also* be installed as Supplemental Packs after installation. This change remembers the use of Driver Disks and makes sure the question is asked, even when the supplemental-packs feature is disabled. Signed-off-by: Yann Dirson <[email protected]>
It may not be obvious to users that local-media Driver Disks must be inserted twice during installation. This change uses the memorization of usage of Driver Disks from previous commit, and uses it to explain users they likely wants to insert their Driver Disk again. Signed-off-by: Yann Dirson <[email protected]>
|
Ping to reviewers 👋 |
|
@stormi before the ping you should make sure all discussions are resolved. By the way, checked they were resolved. Fine for me |
|
I did check they were resolved, at least to my understanding :). I rarely ping despite many pending reviews, by the way. |
|
If you meant the conversations were still open from github's point of view, it's not always obvious in review processes whose responsibility it is to mark them as resolved. The committer, or the reviewer? I usually prefer when it's the reviewer, this way they have a way to have a last look to what they asked and how it was answered, before marking the conversation as resolved. Others may prefer that they are marked as resolved by the committer. |
It sounds reasonable. Personally on my changes if I changed as requested/suggested I put a |
ydirson
force-pushed
the
driver-disks
branch
from
98b5ec1
to
8e88bdb
Compare
|
any news on this one? |
This PR improves the final "Supplemental Packs" dialog when the user made use of Driver Disk(s), and also fixes the handling of Driver Disks when the supplemental-packs feature is disabled (re-enabling the dialog, with the more targeted message).
This is a followup to #28.