Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver disks #24

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Driver disks #24

merged 2 commits into from
Dec 15, 2023

Conversation

ydirson
Copy link
Collaborator

@ydirson ydirson commented Dec 15, 2023

XCP-ng version of xenserver#73 since that one did not get through yet.

In interactive mode, when Driver Disks are used as local media, they
must *also* be installed as Supplemental Packs after installation.
This change remembers the use of Driver Disks and makes sure the
question is asked, even when the supplemental-packs feature is
disabled.

Signed-off-by: Yann Dirson <[email protected]>
It may not be obvious to users that local-media Driver Disks must be
inserted twice during installation.  This change uses the memorization
of usage of Driver Disks from previous commit, and uses it to explain
users they likely wants to insert their Driver Disk again.

Signed-off-by: Yann Dirson <[email protected]>
@ydirson
Copy link
Collaborator Author

ydirson commented Dec 15, 2023

Just tried the in-web "resolve conflicts" here, just remember never to do that...

Problem here was not so much that it made me add a blank line, but that I could not be able to see it before clicking that "sign off and commit" button 😱

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ydirson ydirson merged commit 7485aeb into 10.10.11-8.3 Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants