Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arbitrary axes for resample2d #752

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Allow arbitrary axes for resample2d #752

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99d6c87
Allow arbitrary axes for resample2d
philloooo Aug 20, 2024
a179a9b
add input to check resample options
philloooo Aug 20, 2024
471cc12
update wording
philloooo Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5202,7 +5202,7 @@ partial interface MLGraphBuilder {
</div>

### resample2d ### {#api-mlgraphbuilder-resample2d-method}
Resample the tensor values from the source to the destination spatial dimensions according to the scaling factors.
Resample the tensor values from the source to the destination dimensions according to the axes and scaling factors.
<script type=idl>
enum MLInterpolationMode {
"nearest-neighbor",
Expand Down Expand Up @@ -5237,30 +5237,30 @@ partial interface MLGraphBuilder {
: <dfn>scales</dfn>
::
A list of length 2.
Specifies the scaling factor in each spatial dimensions of the input: *[scaleHeight, scaleWidth]*.
Specifies the scaling factor for each input dimension from {{MLResample2dOptions/axes}} : *[scaleForFirstAxis, scaleForSecondAxis]*.
The default value is [1.0, 1.0].

: <dfn>sizes</dfn>
::
A list of length 2.
Specifies the target sizes for each spatial dimensions of the input: *[sizeHeight, sizeWidth]*. When the target sizes are specified, the {{MLResample2dOptions/scales}} argument is ignored, since the scaling factor values are derived from the target sizes of each spatial dimension of the input.
Specifies the target sizes for each input dimension from {{MLResample2dOptions/axes}} : *[sizeForFirstAxis, ForSecondAxis]*. When the target sizes are specified, the {{MLResample2dOptions/scales}} argument is ignored, since the scaling factor values are derived from the target sizes of the input.

: <dfn>axes</dfn>
::
A list of length 2.
Specifies the two consecutive dimensions of the input tensor to which the interpolation algorithm applies. The valid values are [0, 1], [1, 2] or [2, 3].
Specifies the two dimensions of the input tensor to which the interpolation algorithm applies.
The default value is [2, 3].
</dl>

<details open algorithm>
<summary>
To <dfn for="MLGraphBuilder">check resample options</dfn> given |options|, run the following steps:
To <dfn for="MLGraphBuilder">check resample options</dfn> given |options| and |input|, run the following steps:
</summary>
1. If |options|.{{MLResample2dOptions/scales}} does not [=map/exist=], set it to the [=/list=] « 1.0, 1.0 ».
1. Otherwise, if any of its values is not greater than 0, or if its [=list/size=] is not 2, return false.
1. If |options|.{{MLResample2dOptions/sizes}} [=map/exists=], and if its size is not 2, or if any of its values is not greater than 0, return false.
1. If |options|.{{MLResample2dOptions/axes}} does not [=map/exists=], set it to the [=/list=] « 2, 3 ».
1. Otherwise, if its value is not one of « 0, 1», « 1, 2», « 2, 3 », return false.
1. Otherwise, if |options|.{{MLResample2dOptions/axes}} contains duplicate values, or if any of its elements is not in [=the range=] 0 to |input|'s [=MLOperand/rank=], exclusive, then return false.
philloooo marked this conversation as resolved.
Show resolved Hide resolved
1. Return true.
</details>

Expand All @@ -5286,7 +5286,7 @@ partial interface MLGraphBuilder {
1. If [=MLGraphBuilder/validating operand=] with [=this=] and |input| returns false, then [=exception/throw=] a {{TypeError}}.
1. If |input|'s [=MLOperand/dataType=] is not {{MLOperandDataType/"float32"}} or {{MLOperandDataType/"float16"}}, then [=exception/throw=] a {{TypeError}}.
1. If |input|'s [=MLOperand/rank=] is not 4, then [=exception/throw=] a {{TypeError}}.
1. If [=MLGraphBuilder/checking resample options=] given |options| returns false, then [=exception/throw=] a {{TypeError}}.
1. If [=MLGraphBuilder/checking resample options=] given |options| and |input| returns false, then [=exception/throw=] a {{TypeError}}.
1. Let |desc| be the result of [=MLGraphBuilder/calculating resample output sizes=] given |input| and |options|. If that returns failure, then [=exception/throw=] a {{TypeError}}.
1. *Make graph connections:*
1. Let |output| be the result of [=creating an MLOperand=] given [=this=] and |desc|.
Expand Down